Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): fix two protocol bugs #13034

Merged
merged 6 commits into from
Jan 25, 2023
Merged

fix(protocol): fix two protocol bugs #13034

merged 6 commits into from
Jan 25, 2023

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented Jan 24, 2023

  1. Introduction of blockHashHistory has broken getLatestSyncedHeader, which returns the zero address after the first iteration through blockHashHistory.

  2. verifyBlocks publc function max num blocks arg always verified 1 more than the block numbers specified. ie: passing in 1 verified 2.

@cyberhorsey cyberhorsey requested review from dantaik and davidtaikocha and removed request for dantaik January 24, 2023 08:00
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #13034 (00f6a6f) into main (088933e) will decrease coverage by 0.08%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main   #13034      +/-   ##
==========================================
- Coverage   65.34%   65.27%   -0.08%     
==========================================
  Files         113      113              
  Lines        3105     3104       -1     
  Branches      386      385       -1     
==========================================
- Hits         2029     2026       -3     
- Misses        999     1001       +2     
  Partials       77       77              
Flag Coverage Δ *Carryforward flag
bridge-ui 92.61% <ø> (ø) Carriedforward from 088933e
protocol 57.35% <80.00%> (-0.15%) ⬇️
relayer 69.10% <ø> (ø) Carriedforward from 088933e
ui 100.00% <ø> (ø) Carriedforward from 088933e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ckages/protocol/contracts/L1/libs/LibVerifying.sol 13.33% <0.00%> (ø)
packages/protocol/contracts/L1/TaikoL1.sol 38.00% <100.00%> (-1.22%) ⬇️
packages/protocol/contracts/L1/libs/LibUtils.sol 27.27% <100.00%> (ø)
...ges/protocol/contracts/libs/LibAnchorSignature.sol 89.47% <0.00%> (-10.53%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

dantaik
dantaik previously approved these changes Jan 24, 2023
@dantaik dantaik self-requested a review January 24, 2023 22:20
@dantaik dantaik enabled auto-merge (squash) January 25, 2023 02:02
@dantaik dantaik changed the title fix(protocol): Several protocol fixes. fix(protocol): fix two protocol bugs Jan 25, 2023
@dantaik dantaik requested review from d1onys1us and dantaik and removed request for RogerLamTd and d1onys1us January 25, 2023 13:47
@dantaik dantaik merged commit 1bfa69b into main Jan 25, 2023
@dantaik dantaik deleted the proto_fix branch January 25, 2023 13:48
@github-actions github-actions bot mentioned this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants