fix(website): fix darkmode bug on docs website #13101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d1onys1us
changed the title
|
@d1onys1us any update on this PR status? |
d1onys1us
force-pushed
the
fix-dark-mode
branch
from
b246bcb
to
a40ae26
Compare
|
seems to be a weird issue with nextra, i'll have to bring it up to them. essentially the theme provider is returning undefined, possibly because the navigation bar is not within the scope of the theme provider (prop is not passed down). so i just enabled light mode as the default. of course the user can switch to system or dark theme. this should be a sufficient fix for now. ready for review @cyberhorsey |
shadab-taiko
approved these changes
Feb 15, 2023
dantaik
approved these changes
Feb 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: can reproduce by opening website through discord app, iphone