Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): add isEtherReleased to Bridge #13204

Merged
merged 3 commits into from
Feb 23, 2023
Merged

feat(protocol): add isEtherReleased to Bridge #13204

merged 3 commits into from
Feb 23, 2023

Conversation

cyberhorsey
Copy link
Contributor

BridgeUI needs a way to determine if ether is released without crawling every block for events. It already exists for ERC20 but not for ETH.

@cyberhorsey cyberhorsey marked this pull request as ready for review February 22, 2023 19:57
@cyberhorsey cyberhorsey requested review from dantaik, d1onys1us, davidtaikocha and shadab-taiko and removed request for dantaik February 22, 2023 19:57
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #13204 (e533a2a) into main (9c3fb10) will increase coverage by 0.18%.
The diff coverage is 0.00%.

❗ Current head e533a2a differs from pull request most recent head adcc4b6. Consider uploading reports for the commit adcc4b6 to get more accurate results

@@            Coverage Diff             @@
##             main   #13204      +/-   ##
==========================================
+ Coverage   60.15%   60.33%   +0.18%     
==========================================
  Files         115      115              
  Lines        3448     3444       -4     
  Branches      468      466       -2     
==========================================
+ Hits         2074     2078       +4     
+ Misses       1287     1278       -9     
- Partials       87       88       +1     
Flag Coverage Δ *Carryforward flag
bridge-ui 92.61% <ø> (ø) Carriedforward from 16993cd
protocol 51.38% <0.00%> (+0.32%) ⬆️
relayer 65.15% <ø> (ø) Carriedforward from 16993cd
ui 100.00% <ø> (ø) Carriedforward from 16993cd

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/bridge/Bridge.sol 38.88% <0.00%> (-2.29%) ⬇️
...ges/protocol/contracts/libs/LibAnchorSignature.sol 89.47% <0.00%> (-10.53%) ⬇️
packages/protocol/contracts/L1/TaikoL1.sol 31.48% <0.00%> (ø)
packages/protocol/contracts/L2/TaikoL2.sol 53.84% <0.00%> (ø)
packages/protocol/contracts/L1/TkoToken.sol 84.21% <0.00%> (ø)
packages/protocol/contracts/libs/LibMath.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/libs/LibAddress.sol 66.66% <0.00%> (ø)
packages/protocol/contracts/libs/LibTxUtils.sol 96.55% <0.00%> (ø)
packages/protocol/contracts/L1/ProofVerifier.sol 0.00% <0.00%> (ø)
... and 23 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik self-requested a review February 23, 2023 02:25
@dantaik dantaik added this pull request to the merge queue Feb 23, 2023
Merged via the queue into main with commit f39e65d Feb 23, 2023
@dantaik dantaik deleted the is_ether_released branch February 23, 2023 02:29
@github-actions github-actions bot mentioned this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants