Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): let PlonkVerifier return keccak256("taiko") #13277

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

davidtaikocha
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #13277 (e1b1d72) into main (9cb1740) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #13277      +/-   ##
==========================================
- Coverage   61.61%   61.56%   -0.05%     
==========================================
  Files         118      118              
  Lines        3478     3479       +1     
  Branches      491      491              
==========================================
- Hits         2143     2142       -1     
- Misses       1250     1253       +3     
+ Partials       85       84       -1     
Flag Coverage Δ *Carryforward flag
bridge-ui 94.52% <ø> (ø) Carriedforward from 9cb1740
protocol 52.29% <100.00%> (-0.09%) ⬇️
relayer 64.71% <ø> (ø) Carriedforward from 9cb1740
ui 100.00% <ø> (ø) Carriedforward from 9cb1740

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/libs/LibZKP.sol 100.00% <100.00%> (ø)
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 83.13% <0.00%> (-7.23%) ⬇️
...ges/protocol/contracts/libs/LibAnchorSignature.sol 100.00% <0.00%> (+10.52%) ⬆️
...s/protocol/contracts/test/thirdparty/TestERC20.sol 100.00% <0.00%> (+100.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik added this pull request to the merge queue Mar 9, 2023
Merged via the queue into main with commit 8ca632c Mar 9, 2023
@dantaik dantaik deleted the plonk-verifier-return-value branch March 9, 2023 09:15
@github-actions github-actions bot mentioned this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants