Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): update LibBlockHeader to hash post Shanghai fork blocks #13278

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

davidtaikocha
Copy link
Contributor

Since Sepolia has already activated Shanghai hard fork, we need to update the block hash calculation in LibBlockHeader to ensure HeaderSyncer can still work as expected. Will dig into EIP-4895 later to see how it works in go-ethereum.

@d1onys1us d1onys1us self-requested a review March 9, 2023 07:34
d1onys1us
d1onys1us previously approved these changes Mar 9, 2023
Copy link
Contributor

@d1onys1us d1onys1us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it and worked for me.

@davidtaikocha

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #13278 (0c871f9) into main (9cb1740) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #13278      +/-   ##
==========================================
- Coverage   61.61%   61.54%   -0.08%     
==========================================
  Files         118      118              
  Lines        3478     3482       +4     
  Branches      491      493       +2     
==========================================
  Hits         2143     2143              
- Misses       1250     1255       +5     
+ Partials       85       84       -1     
Flag Coverage Δ *Carryforward flag
bridge-ui 94.52% <ø> (ø) Carriedforward from 9cb1740
protocol 52.25% <100.00%> (-0.12%) ⬇️
relayer 64.71% <ø> (ø) Carriedforward from 9cb1740
ui 100.00% <ø> (ø) Carriedforward from 9cb1740

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ackages/protocol/contracts/libs/LibBlockHeader.sol 93.33% <100.00%> (+1.02%) ⬆️
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 83.13% <0.00%> (-7.23%) ⬇️
...ges/protocol/contracts/libs/LibAnchorSignature.sol 100.00% <0.00%> (+10.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@d1onys1us d1onys1us added this pull request to the merge queue Mar 9, 2023
Merged via the queue into main with commit 2e34634 Mar 9, 2023
@d1onys1us d1onys1us deleted the fix-sepolia-lib-block-header branch March 9, 2023 10:19
@github-actions github-actions bot mentioned this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants