feat(protocol): Add reward and fee fields to events #13808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overall, the changes in this pull request look good. Here are some points to consider:
- In TaikoEvents.sol, consider changing the name of the blockFee variable to something more descriptive.
- In LibProposing.sol, consider adding comments to explain why blockFee is being set twice.
- In LibVerifying.sol, consider adding a comment to explain why reward is set to 0 for the genesis block.
- Consider adding comments to explain the purpose of each event in TaikoEvents.sol and LibVerifying.sol.
- Consider using consistent naming conventions for variables and functions across all three files.
davidtaikocha
approved these changes
May 24, 2023
cyberhorsey
approved these changes
May 24, 2023
Merged
davidtaikocha
pushed a commit
that referenced
this pull request
May 26, 2023
Co-authored-by: adaki2004 <adaki2004@users.noreply.github.com>
davidtaikocha
added a commit
that referenced
this pull request
May 26, 2023
…3820) Co-authored-by: D <51912515+adaki2004@users.noreply.github.com> Co-authored-by: adaki2004 <adaki2004@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to issue: #13807