Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo): fix openAI review workflow #13844

Merged
merged 5 commits into from
Jun 1, 2023
Merged

fix(repo): fix openAI review workflow #13844

merged 5 commits into from
Jun 1, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented May 31, 2023

No description provided.

@dantaik dantaik changed the title Update openai-review.yml fix(repository): fix openAI review workflow May 31, 2023
@dantaik dantaik marked this pull request as ready for review May 31, 2023 06:19
@dantaik dantaik enabled auto-merge May 31, 2023 06:19
@dantaik dantaik changed the title fix(repository): fix openAI review workflow fix(repo): fix openAI review workflow May 31, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the pull request looks good. However, there are a few points to note:

  • In patch 1/5, the label name is different from that of the other patches. It should be changed to 'option.review-by-ai' to be consistent with the other patches.
  • In patch 3/5, there is an extra space before the 'if' statement which should be removed.
  • In patch 5/5, it seems that the 'if' statement is checking for pull_request labels instead of issue labels; this should be changed to check for issue labels.

@dantaik dantaik added this pull request to the merge queue Jun 1, 2023
Merged via the queue into main with commit 2cb0cfa Jun 1, 2023
7 checks passed
@dantaik dantaik deleted the change_label branch June 1, 2023 07:37
@github-actions github-actions bot mentioned this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants