Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): use ring buffer for ETH deposit and optimize storage #13868

Merged
merged 23 commits into from
Jun 16, 2023
Merged

feat(protocol): use ring buffer for ETH deposit and optimize storage #13868

merged 23 commits into from
Jun 16, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jun 3, 2023

  • use ring buffer to keep the pending ETH deposits
  • optimize storage to use one uint256 for each deposit (1 slot vs 2 slots)

@dantaik dantaik self-assigned this Jun 3, 2023
@dantaik dantaik marked this pull request as ready for review June 3, 2023 14:11
@dantaik dantaik linked an issue Jun 3, 2023 that may be closed by this pull request
Use ring buffer for pending Ether Deposits #13783
Closed
@dantaik dantaik mentioned this pull request Jun 3, 2023
Closed
@dantaik dantaik enabled auto-merge June 3, 2023 14:25
@adaki2004
Copy link
Contributor

Build warnings:
TaikoData.State storage state unused: contracts/L1/libs/LibVerifying.sol:155
address systemProver unusued: contracts/L1/libs/LibVerifying.sol:159

@dantaik dantaik added this pull request to the merge queue Jun 16, 2023
Merged via the queue into main with commit acffb61 Jun 16, 2023
13 of 16 checks passed
@dantaik dantaik deleted the deposit_ringbuff branch June 16, 2023 08:36
@github-actions github-actions bot mentioned this pull request Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adaki2004 adaki2004 adaki2004 approved these changes

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@cyberhorsey cyberhorsey Awaiting requested review from cyberhorsey

Assignees

@dantaik dantaik

Labels
area.protocol category.feature meta.alpha-4
Projects
Taiko Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use ring buffer for pending Ether Deposits
3 participants
@dantaik @adaki2004 @davidtaikocha