feat(bridge-ui-v2): switch chain #14117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is ERC1155 an superset of ERC721? If so, maybe for all ERC721 tokens, we just treat them as ERC1155? |
Are you sure you wanted to ask it here ? Anyhow, the answer is: it is implementation (erc1155) dependent. I'd handle them separately. (Not a big deal / difference) APIs towards client/relayer shall be similar but the message structure will be different. |
jscriptcoder
requested review from
d1onys1us,
adaki2004,
dantaik,
davidtaikocha and
KorbinianK
d1onys1us
previously approved these changes
Jul 7, 2023
dantaik
previously approved these changes
Jul 8, 2023
Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>
davidtaikocha
approved these changes
Jul 10, 2023
dantaik
approved these changes
Jul 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching chains and updating state