feat(website): update wallet setup docs #14209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
approved these changes
Jul 19, 2023
MarcusWentz
approved these changes
Jul 19, 2023
Merged
d1onys1us
reviewed
Jul 19, 2023
| | typeof GRIMSVOTN_CONFIG.names.shortName; | ||
| }; | ||
|
|
||
| const chainMap = { |
There was a problem hiding this comment.
we shouldn't initialize constants here if we need this mapping we should expose it out of the domain folder
|
|
||
| ### Add tokens to your wallet | ||
| Use your wallet (e.g., Metamask) to [import the tokens](https://support.ledger.com/hc/en-us/articles/6375103346077-Add-custom-tokens-to-MetaMask?docs=true). You can find all deployed tokens contract addresses [here](/docs/reference/contract-addresses). | ||
| <AddTokenButton address={SEPOLIA_CONFIG.basedContracts.erc20Contracts.taikoToken.address.proxy} |
There was a problem hiding this comment.
we should either add a vertical margin to the bottom or break elements as it's rendering squished 
d1onys1us
reviewed
Jul 19, 2023
| }: AddTokenButtonProps) { | ||
| return ( | ||
| <div | ||
| onClick={() => addTokenToWallet({ address, symbol, decimals, image })} | ||
| onClick={() => addTokenToWallet({ address, symbol, decimals, image, network })} | ||
| className="hover:cursor-pointer text-neutral-100 bg-[#E81899] hover:bg-[#d1168a] border-solid border-neutral-200 focus:ring-4 focus:outline-none focus:ring-neutral-100 font-medium rounded-lg text-sm px-3 py-2 text-center inline-flex items-center" |
There was a problem hiding this comment.
nit: we should consider refactoring out a button class now that we are using it so frequently: ecosystem page, homepage, here, and add wallet.
this could be a good first issue as well i think for community.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.