fix(bridge-ui-v2): processing fee and amount input validation #14220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jscriptcoder
commented
Jul 20, 2023
•
jscriptcoder
commented
- Made changes around Processing Fee according to new design changes
- Improved validation in the amount input:
- Insufficient Balance error
- Insufficient Allowance warning
- Some minor refactoring
…nto bridge_eth
jscriptcoder
requested review from
KorbinianK,
d1onys1us,
adaki2004,
dantaik,
davidtaikocha and
cyberhorsey
jscriptcoder
changed the title
dantaik
approved these changes
Jul 20, 2023
KorbinianK
approved these changes
Jul 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.