Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(website): use cards in guides #14378

Merged
merged 17 commits into from
Aug 11, 2023
Merged

feat(website): use cards in guides #14378

merged 17 commits into from
Aug 11, 2023

Conversation

2manslkh
Copy link
Contributor

@2manslkh 2manslkh commented Aug 4, 2023

No description provided.

d1onys1us
d1onys1us previously approved these changes Aug 4, 2023
View reviewed changes
dantaik
dantaik previously approved these changes Aug 4, 2023
View reviewed changes
@2manslkh 2manslkh dismissed stale reviews from dantaik and d1onys1us via 44c61a8 August 6, 2023 09:13
Brechtpd and others added 7 commits August 8, 2023 09:20
@Brechtpd @davidtaikocha
@dantaik @2manslkh
feat(protocol): Gas limit behavior changes (#14339)
c620faa 
Co-authored-by: David <david@taiko.xyz>
Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com>
@KorbinianK @2manslkh
feat(bridge-ui-v2): Style adjustments (#14350)
3266faa
@tacrew @davidtaikocha
@d1onys1us @2manslkh
docs(website): add remove orphans option for start L2 node command (#…
727e2cb 
…14311)

Co-authored-by: David <david@taiko.xyz>
Co-authored-by: d1onys1us <13951458+d1onys1us@users.noreply.github.com>
@2manslkh
feat(website): add morkie to ecosystem (#14401)
a301020
@TIGGERLAND @d1onys1us @2manslkh
docs(website): Update troubleshooting procedures in node-troubleshoot…
87163db 
…ing.mdx (#14390)

Co-authored-by: d1onys1us <13951458+d1onys1us@users.noreply.github.com>
@IchiCoin @d1onys1us @2manslkh
docs(website): Update claim-prover-rewards.mdx (#14368)
920aead 
Co-authored-by: d1onys1us <13951458+d1onys1us@users.noreply.github.com>
@2manslkh @d1onys1us
feat(website): update node running guides (#14400)
558d78c 
Co-authored-by: d1onys1us <13951458+d1onys1us@users.noreply.github.com>
@2manslkh 2manslkh enabled auto-merge August 8, 2023 02:25
d1onys1us
d1onys1us previously approved these changes Aug 8, 2023
View reviewed changes
MarcusWentz
MarcusWentz suggested changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@MarcusWentz MarcusWentz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the emojis on the guides page and side tabs are changing inconsistently.

Please remove these changes and open a seperate PR for us to review.

@dantaik dantaik self-requested a review August 10, 2023 07:09
dantaik
dantaik previously approved these changes Aug 11, 2023
View reviewed changes
@dantaik
Copy link
Contributor

dantaik commented Aug 11, 2023

@MarcusWentz @2manslkh This PR is getting old, could you guys work together to resolve pending feedbacks then review it again?

@2manslkh 2manslkh dismissed stale reviews from dantaik and d1onys1us via c0b64bc August 11, 2023 03:53
@dantaik dantaik removed the request for review from MarcusWentz August 11, 2023 09:21
@MarcusWentz MarcusWentz self-requested a review August 11, 2023 12:23
@MarcusWentz MarcusWentz added this pull request to the merge queue Aug 11, 2023
Merged via the queue into main with commit cd1db4a Aug 11, 2023
9 of 12 checks passed
@MarcusWentz MarcusWentz deleted the docs-visuals branch August 11, 2023 12:24
@github-actions github-actions bot mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d1onys1us d1onys1us d1onys1us approved these changes

@MarcusWentz MarcusWentz MarcusWentz approved these changes

@dantaik dantaik dantaik approved these changes

Assignees
No one assigned
Labels
area.website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet