feat(website): Improve behavior on adding chains and tokens #14781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nakochi-crypto is attempting to deploy a commit to the taikoxyz Team on Vercel. A member of the Team first needs to authorize it. |
d1onys1us
approved these changes
Sep 25, 2023
|
this is a great improvement, thanks @Nakochi-crypto! |
2manslkh
approved these changes
Sep 25, 2023
Merged
|
@d1onys1us Thanks! Can you give me a GitPoap? |
@gitpoap-bot please award @Nakochi-crypto |
|
Congrats, @Nakochi-crypto ! You've earned a GitPOAP for your contribution! GitPOAP: 2023 Taiko Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
KorbinianK
pushed a commit
that referenced
this pull request
Sep 28, 2023
Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>
KorbinianK
pushed a commit
that referenced
this pull request
Sep 28, 2023
Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves these behaviors below on the docs.
https://taiko.xyz/docs/guides/setup-your-wallet
Also, this removes ethereumRequest because it won't throw errors and the callers can't handle them.