Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): increase GAS_OVERHEAD value based on testnet data #16769

Merged
merged 1 commit into from Apr 19, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 19, 2024

Based on testnet processMessage transaction, the GAS_OVERHEAD value should be increased to at least 100K. I set the value to 120K considering that the merkle proofs will grow bigger in size once there are many signals written.

https://internal.taikoscan.io/tx/0x51c1c0d3c011c2c8d738ff5e18394ed18c9d2f058942760e24da5625d726db62/logs and a few other processMessage txs.

@dantaik dantaik requested a review from Brechtpd April 19, 2024 04:23
@dantaik dantaik marked this pull request as ready for review April 19, 2024 04:23
Copy link

feat(protocol: increase GAS_OVERHEAD value based on testnet data

Generated at commit: ca387abaf67afce60961e4c255f2222996d5cc83

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
4
40
48
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@Brechtpd Brechtpd changed the title feat(protocol: increase GAS_OVERHEAD value based on testnet data feat(protocol): increase GAS_OVERHEAD value based on testnet data Apr 19, 2024
@dantaik dantaik added this pull request to the merge queue Apr 19, 2024
Merged via the queue into main with commit fb9334c Apr 19, 2024
9 of 10 checks passed
@dantaik dantaik deleted the adjust_gas_overhead branch April 19, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants