Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repo): add taikoon and supplementary-contracts sub packages #16810

Merged
merged 13 commits into from
Apr 24, 2024
Merged

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 23, 2024

Misc contracts that are not part of the core rollup protocol, including token airdrops, token grant, etc, I hope to move them to this new package eventually.

@dantaik dantaik marked this pull request as ready for review April 23, 2024 05:24
@dantaik dantaik requested a review from 2manslkh April 23, 2024 05:25
@dantaik dantaik enabled auto-merge April 23, 2024 05:25
@dantaik dantaik changed the title feat(taikoon): init the Taiko NFT contract package feat(repo): init the Taiko NFT contract package Apr 23, 2024
Copy link

openzeppelin-code bot commented Apr 23, 2024

feat(repo): add taikoon and supplementary-contracts sub packages

Generated at commit: a2a87d3712d9cbff194fb548811264d30edf80f7

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
6
40
50
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik changed the title feat(repo): init the Taiko NFT contract package feat(repo): add 'taikoon' and 'opcontracts' sub packages Apr 23, 2024
@dantaik dantaik changed the title feat(repo): add 'taikoon' and 'opcontracts' sub packages feat(repo): add 'opcontracts' sub packages Apr 23, 2024
This reverts commit 5366a3b.
@dantaik dantaik changed the title feat(repo): add 'opcontracts' sub packages feat(repo): add taikoon and opcontracts sub packages Apr 23, 2024
Copy link
Contributor

@Brechtpd Brechtpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opcontracts might be a bit confusing because it's used as a prefix for optimism's tech (op-stack, op-node, ...). That's also what I thought when first reading the name here that this would be a folder for the op contracts that we use in the protocol. :)

Not sure what a better name would be though, maybe just contracts?

image

packages/opcontracts/README.md Outdated Show resolved Hide resolved
@dantaik dantaik changed the title feat(repo): add taikoon and opcontracts sub packages feat(repo): add taikoon and supplementary-contracts sub packages Apr 23, 2024
@dantaik
Copy link
Contributor Author

dantaik commented Apr 23, 2024

opcontracts might be a bit confusing because it's used as a prefix for optimism's tech (op-stack, op-node, ...). That's also what I thought when first reading the name here that this would be a folder for the op contracts that we use in the protocol. :)

Not sure what a better name would be though, maybe just contracts?

image

renamed to supplementary-contracts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants