Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge-ui): update disabled for chainselector #16814

Merged
merged 7 commits into from
Apr 24, 2024

Conversation

monleru
Copy link
Contributor

@monleru monleru commented Apr 23, 2024

Select error before connecting the wallet.

Before update:
Select opens but the change is not active which looks like a bug.
Any actions are not active until the wallet is connected.
I think it's not supposed to work like that - https://www.youtube.com/watch?v=1GyqVcW-Xuc

image

After the update:
Select is active only after the wallet is connected.
image

@monleru monleru changed the title feat(bridge-ui): Update disabled for ChainSelector fix (bridge-ui): update disabled for chainselector Apr 23, 2024
@monleru monleru marked this pull request as ready for review April 23, 2024 18:35
@monleru monleru changed the title fix (bridge-ui): update disabled for chainselector fix(bridge-ui): update disabled for chainselector Apr 23, 2024
@dantaik dantaik requested a review from KorbinianK April 24, 2024 06:44
monleru and others added 2 commits April 24, 2024 09:56
…inPill.svelte

Co-authored-by: Korbinian <KorbinianK@users.noreply.github.com>
…inPill.svelte

Co-authored-by: Korbinian <KorbinianK@users.noreply.github.com>
@monleru monleru requested a review from KorbinianK April 24, 2024 06:59
@davidtaikocha davidtaikocha added this pull request to the merge queue Apr 24, 2024
Merged via the queue into taikoxyz:main with commit 406b15a Apr 24, 2024
4 of 5 checks passed
Copy link

gitpoap-bot bot commented Apr 24, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Taiko Contributor:

GitPOAP: 2024 Taiko Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants