feat(protocol): change min base fee to 0.01 gwei #16914
Merged
+15
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(protocol): change min base fee to 0.01 gwei
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
adaki2004
approved these changes
Apr 29, 2024
davidtaikocha
approved these changes
Apr 29, 2024
Brechtpd
approved these changes
Apr 29, 2024
| console2.log("base fee:", i, baseFee); | ||
| } | ||
|
|
||
| // base fee will reach 1 gwei if gasExcess > 18540000000 |
There was a problem hiding this comment.
Suggested change
| // base fee will reach 1 gwei if gasExcess > 18540000000 | |
| // base fee will reach 0.1 gwei if gasExcess > 18540000000 |
|
|
||
| for (; baseFee < 1 gwei; ++i) { | ||
| baseFee = Lib1559Math.basefee(config.gasTargetPerL1Block * i, adjustmentFactor); | ||
| console2.log("base fee:", i, baseFee); | ||
| } | ||
|
|
||
| // base fee will reach 1 gwei if gasExcess > 19620000000 | ||
| // base fee will reach 10 gwei if gasExcess > 19620000000 |
There was a problem hiding this comment.
Suggested change
| // base fee will reach 10 gwei if gasExcess > 19620000000 | |
| // base fee will reach 1 gwei if gasExcess > 19620000000 |
| @@ -33,7 +41,7 @@ contract TestLib1559Math is TaikoTest { | |||
| } | |||
|
|
|||
| // base fee will reach 10 gwei if gasExcess > 20760000000 | |||
| console2.log("base fee will reach 10 gwei if gasExcess >", config.gasTargetPerL1Block * i); | |||
| console2.log("base fee will reach 1 gwei if gasExcess >", config.gasTargetPerL1Block * i); | |||
There was a problem hiding this comment.
Suggested change
| console2.log("base fee will reach 1 gwei if gasExcess >", config.gasTargetPerL1Block * i); | |
| console2.log("base fee will reach 10 gwei if gasExcess >", config.gasTargetPerL1Block * i); |
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current 0.1 gwei base fee is still too large comparing with some alternative L2s.