Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): implement timestamp based checkpoints for TKO & BridgedERC20 #16932

Merged
merged 14 commits into from
May 1, 2024
Merged

feat(protocol): implement timestamp based checkpoints for TKO & BridgedERC20 #16932

merged 14 commits into from
May 1, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 30, 2024

No description provided.

@dantaik dantaik requested a review from adaki2004 April 30, 2024 11:06
@dantaik dantaik marked this pull request as ready for review April 30, 2024 11:06
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Apr 30, 2024 •
edited

feat(protocol): implement timestamp based checkpoints for TKO & BridgedERC20

Generated at commit: 3e852510b1f7ec7cee62e95e9a3d12b35c46fcb2

馃毃 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
5
40
49
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik requested a review from brickpop April 30, 2024 12:29
adaki2004
adaki2004 previously approved these changes Apr 30, 2024
View reviewed changes
@adaki2004 @Brechtpd
Update packages/protocol/contracts/tokenvault/ERC20Vault.sol
9ef3e7c 
Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>
@dantaik dantaik changed the base branch from main to safe_guard_tokens April 30, 2024 12:48
@dantaik dantaik changed the base branch from safe_guard_tokens to del-gov April 30, 2024 12:50
Base automatically changed from del-gov to main April 30, 2024 12:52
@dantaik dantaik dismissed adaki2004鈥檚 stale review April 30, 2024 12:52

The base branch was changed.

@dantaik
Copy link
Contributor Author

dantaik commented Apr 30, 2024

@davidtaikocha we need to deploy this new version and perform a L1 upgrade to the TKO token contract.

@dantaik dantaik requested a review from Brechtpd April 30, 2024 14:04
@dantaik dantaik enabled auto-merge May 1, 2024 03:26
@dantaik dantaik added this pull request to the merge queue May 1, 2024
Merged via the queue into main with commit 56dddf2 May 1, 2024
7 checks passed
@dantaik dantaik deleted the timestamp-mode branch May 1, 2024 03:29
This was referenced May 9, 2024
Merged
Closed
@taiko-kitty taiko-kitty mentioned this pull request Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brickpop brickpop brickpop approved these changes

@Brechtpd Brechtpd Brechtpd approved these changes

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@adaki2004 adaki2004 Awaiting requested review from adaki2004

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dantaik @brickpop @Brechtpd @adaki2004 @davidtaikocha