Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preprocessor): fix hardhat preprocessor configs #368

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

davidtaikocha
Copy link
Contributor

Update some outdated constant names in hardhat preprocessor, which we are using to replace some protocol constants before compiling.

@davidtaikocha davidtaikocha marked this pull request as ready for review November 30, 2022 14:55
@davidtaikocha davidtaikocha changed the title fix(preprocess): fix hardhat preprocessor configs fix(hardhat-preprocessor): fix hardhat preprocessor configs Nov 30, 2022
@davidtaikocha davidtaikocha changed the title fix(hardhat-preprocessor): fix hardhat preprocessor configs fix(preprocessor): fix hardhat preprocessor configs Nov 30, 2022
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #368 (ae08ff2) into main (69e9362) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
+ Coverage   64.57%   64.66%   +0.08%     
==========================================
  Files          88       88              
  Lines        2442     2442              
  Branches      275      275              
==========================================
+ Hits         1577     1579       +2     
+ Misses        793      791       -2     
  Partials       72       72              
Flag Coverage Δ *Carryforward flag
protocol 60.45% <ø> (+0.14%) ⬆️
relayer 68.92% <ø> (ø) Carriedforward from 69e9362
ui 100.00% <ø> (ø) Carriedforward from 69e9362

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ges/protocol/contracts/libs/LibAnchorSignature.sol 100.00% <0.00%> (+10.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@d1onys1us d1onys1us merged commit 8bdbb3e into main Dec 1, 2022
@d1onys1us d1onys1us deleted the fix-preprocessor branch December 1, 2022 03:50
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants