Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure dedupe settings #2182

Closed
tusharmath opened this issue Jun 13, 2024 · 5 comments · Fixed by #2183
Closed

Restructure dedupe settings #2182

tusharmath opened this issue Jun 13, 2024 · 5 comments · Fixed by #2183
Labels

Comments

@tusharmath
Copy link
Contributor

tusharmath commented Jun 13, 2024

At present, we have three configurations:

// mod config::server
struct Server {
  batch_execution: Option<bool>
}

// mod config::upstream
struct Upstream {
  dedupe: Option<bool>,
  dedupe_in_flight: Option<bool>
}

We need to merge these configurations into a single one:

// mod config::server
struct Server {
  dedupe: Option<bool>
}

When this new dedupe configuration is enabled, it should automatically enable all the features that were previously dependent on the dedupe_in_flight and batch_execution flags.

Note: Update documentation with the new settings.

@tusharmath tusharmath added the good first issue Good for newcomers. label Jun 13, 2024
@tusharmath
Copy link
Contributor Author

/bounty 15$

Copy link

algora-pbc bot commented Jun 13, 2024

💎 $15 bounty • Tailcall Inc.

Steps to solve:

  1. Start working: Comment /attempt #2182 with your implementation plan
  2. Submit work: Create a pull request including /claim #2182 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

🙏 Thank you for contributing to tailcallhq/tailcall!
🧐 Checkout our guidelines before you get started.

Attempt Started (GMT+0) Solution
🔴 @thesapan Jun 13, 2024, 10:43:33 AM WIP

@thesapan
Copy link
Contributor

thesapan commented Jun 13, 2024

/attempt 2182

Algora profile Completed bounties Tech Active attempts Options
@thesapan 2 tailcallhq bounties
Cancel attempt

Copy link

algora-pbc bot commented Jun 14, 2024

@thesapan: Reminder that in 1 days the bounty will become up for grabs, so please submit a pull request before then 🙏

Copy link

algora-pbc bot commented Jun 15, 2024

The bounty is up for grabs! Everyone is welcome to /attempt #2182 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants