Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is ModelResourceComponentBuilder intended to exclude fillable properties? #265

Open
KrisalisKAT opened this issue Jun 21, 2024 · 0 comments

Comments

@KrisalisKAT
Copy link

In ModelResourceComponentBuilder@getPropertiesFromSchema, columns are filtered to exclude fillable properties

        return collect($columns)
            ->filter(
                function (Column $column) use ($resourceModel) {
                    return !$resourceModel->isFillable($column->getName());
                }
            )

That code has been in place for about 2 years, but it still seems to be an error. BaseModelComponentBuilder has a similar function, but has the reverse filter - including only fillable properties. And we're having to override the class to reverse the filter in order to get a corrected schema.

Am I overlooking a reason why this is intended behavior, or can that ! be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant