Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label is not ascii errors with hostnames containing utf8 characters #48

Open
ishanjain28 opened this issue Nov 17, 2023 · 1 comment
Open

Comments

@ishanjain28
Copy link

This library here

dns-parser/src/name.rs

Lines 75 to 77 in 1912667

if !parse_data[pos+1..end].is_ascii() {
return Err(Error::LabelIsNotAscii);
}
returns a LabelIsNotAscii error when it encounters queries or answers with label or hostnames containing utf8 characters.

With "normal" DNS queries, utf8 characters are converted to puny code. Multicast DNS queries have the exact same structure except they allow ascii or utf8 characters.[1]

I don't know if it's within the scope of this project. If it is, I believe that line should be changed to allow any utf8 encoded string.

[1] https://datatracker.ietf.org/doc/html/rfc6762#appendix-F

@wfeii1980
Copy link

wfeii1980 commented Jan 31, 2024

The same question!

2024-01-31 18-21-29屏幕截图

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants