Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redisShake 目标端写入的连接是不是没有保活 #758

Closed
ntuwang opened this issue Jan 8, 2024 · 4 comments
Closed

redisShake 目标端写入的连接是不是没有保活 #758

ntuwang opened this issue Jan 8, 2024 · 4 comments
Labels
type: bug Something isn't working type: question Further information is requested

Comments

@ntuwang
Copy link

ntuwang commented Jan 8, 2024

问题描述(Issue Description)

在rdb全量阶段,如果耗时很长,超过了目前端集群的timeout 链接会被kill掉,所以问下是不是没有做目标端的keepalive?

环境信息(Environment)

  • RedisShake 版本4.0.2
  • Redis 源端版本 4.0.14
  • Redis 目的端版本(4.0.14
  • Redis 部署方式cluster
@ntuwang ntuwang added the type: question Further information is requested label Jan 8, 2024
@suxb201 suxb201 added the type: bug Something isn't working label Jan 8, 2024
@suxb201
Copy link
Member

suxb201 commented Jan 8, 2024

是的

@ntuwang
Copy link
Author

ntuwang commented Jan 8, 2024

image
目前我是在NewRedisClusterWriter,新起一个协程去处理,麻烦大佬帮忙看看这样是不是对的,或者有没有什么潜在的坑

@suxb201
Copy link
Member

suxb201 commented Jan 8, 2024

@ntuwang 有竞争。简单改的话可以 Write 里面加一个锁。

@ntuwang
Copy link
Author

ntuwang commented Jan 8, 2024

OK 谢大佬

@suxb201 suxb201 mentioned this issue Mar 5, 2024
@suxb201 suxb201 closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants