New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mutiple Views? #14
Comments
Thank you for feedback! |
Nice! |
@shiraji ActivityTransitionLauncher.with(SearchResultsActivity.this).from(v.findViewById(R.id.comic_title),"title").from(v.findViewById(R.id.thumbnail),"image").image(bitmap).launch(intent); ActivityTransition.with(getActivity().getIntent()).duration(1000).to(tvTitle,"title").to(pvComic,"image").start(null); This it is the original method. Do you have better interface idea? By the way, If you are interested, Please fix this or tell me solution. |
You're welcome. It's hard to see long code in one line in GitHub. I rewrote what you show me. // what you want to do...i guess
ActivityTransitionLauncher
.with(SearchResultsActivity.this)
.from(v.findViewById(R.id.comic_title),"title")
.from(v.findViewById(R.id.thumbnail),"image")
.image(bitmap)
.launch(intent); // what current project does
ActivityTransition
.with(getActivity().getIntent())
.duration(1000)
.to(tvTitle,"title")
.to(pvComic,"image")
.start(null); First of all, I haven't have any chance writing code for this library. Could you give me a few days to read this library? As my first inspiration, I think your interface is good to go. Definitely, I want to do this or #3 or both of them, but you can free to complete these issues. (not even read what issue is for #3, yet 😱 ) |
Sure :) |
Nice one. Shibuya event at Roppongi! Enjoy. I don't think we should be so hurry for these issue, since it is enhancement of the library. |
Multiple views animation is not good on design guideline. https://material.google.com/motion/material-motion.html#material-motion-what-makes-a-good-transition
|
I'm trying to animate an ImageView and a TextView.
My code:
ActivityTransitionLauncher.with(SearchResultsActivity.this).from(v.findViewById(R.id.comic_title)).from(v.findViewById(R.id.thumbnail)).image(bitmap).launch(intent);
ActivityTransition.with(getActivity().getIntent()).duration(1000).to(tvTitle).to(pvComic).start(null);
For some reason only the ImageView is animated, the TextView is not.
The text was updated successfully, but these errors were encountered: