Skip to content
This repository has been archived by the owner on Dec 18, 2021. It is now read-only.

Stale maven-wrapper.jar bundled with maven-wrapper-{version}.tar.gz since 0.1.4 #37

Closed
mches opened this issue Mar 8, 2017 · 3 comments

Comments

@mches
Copy link

mches commented Mar 8, 2017

When building master, which is currently at 0.1.7-SNAPSHOT, a maven-wrapper.jar is magically installed in target/maven-wrapper-0.1.7-SNAPSHOT/.mvn/wrapper/maven-wrapper.jar. DEBUG logging doesn't indicate anything useful. The contents are always stale with a timestamp of 4/3/2015 1:07 AM.

META-INF/MANIFEST.MF:

Manifest-Version: 1.0
Implementation-Title: maven-wrapper
Implementation-Version: 0.1.2-SNAPSHOT
Implementation-Vendor-Id: io.takari
Build-Jdk: 1.7.0_67
Built-By: jvanzyl
Specification-Title: maven-wrapper
Created-By: Takari Inc.
Specification-Version: 0.1.2-SNAPSHOT
Archiver-Version: Provisio Archiver

This jar is added to target/maven-wrapper-0.1.7-SNAPSHOT.tar.gz which is later installed in the local repository. I've found that target/maven-wrapper-0.1.7-SNAPSHOT.jar and target/maven-wrapper-0.1.7-SNAPSHOT-sources.jar are not stale. The other 3 files in target/maven-wrapper-0.1.7-SNAPSHOT.tar.gz (mvnw, mvnw.cmd and maven-wrapper.properties) are not stale.

Incidentally, all versions since 0.1.2 (i.e. 0.1.4, 0.1.5 and 0.1.6) in Maven Central contain this stale jar.

@mches
Copy link
Author

mches commented Mar 8, 2017

After doing all that analysis, it became pretty clear the bug was introduced here. The stale maven-wrapper.jar at ${basedir}/.mvn/wrapper/maven-wrapper.jar was overwriting the project artifact for the purpose of assembling the .tar.gz distribution. A straight-forward fix is part of PR #36.

@mosabua
Copy link
Member

mosabua commented Apr 5, 2017

Committed fix, will release 0.2.0 shortly with fix

@mosabua mosabua closed this as completed Apr 5, 2017
@mosabua
Copy link
Member

mosabua commented Apr 17, 2017

Fyi maven-wrapper:0.2.0 and and takari-maven-plugin:0.4.0 are released to Central.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants