Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 6 #27

Closed
mkamensky opened this issue Aug 24, 2019 · 9 comments
Closed

Rails 6 #27

mkamensky opened this issue Aug 24, 2019 · 9 comments

Comments

@mkamensky
Copy link

Is there an issue supporting it? Thanks

@zachaysan
Copy link
Collaborator

There are some failing tests, yeah. From my vantage point it looks like ActiveRecord has some poorly generated SQL after the latest refactor, so I'm inclined to wait it out and hope it fixes itself. But if you'd like to try your own hand at it, it's a pretty easy repo to get the tests running in, though you do need sudo in order to create the test db.

@zachaysan
Copy link
Collaborator

@mkamensky I think I have a fix ready here. I'm going cut a gem. Let me know if there are problems in your test suite.

@zachaysan
Copy link
Collaborator

Ok latest Gem has a fix for Rails 6 support, let me know if there are any other issues.

@mkamensky
Copy link
Author

Thank you!

@mkamensky
Copy link
Author

Now 6.0.1 is here...

@zachaysan
Copy link
Collaborator

What's the issue @mkamensky ?

@anfinil
Copy link
Contributor

anfinil commented Nov 6, 2019

#28 fixes it

@mkamensky
Copy link
Author

Thanks, for the issue was simply that rails 6.0.1 is incompatible with the latest version, bundle was pulling an old one.

@zachaysan
Copy link
Collaborator

Ah, gotcha. Thanks for the PR @anfinil I've cut the new gem let me know if there are any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants