Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pops up everytime #19

Closed
HelloDev18 opened this issue Dec 8, 2018 · 5 comments
Closed

Pops up everytime #19

HelloDev18 opened this issue Dec 8, 2018 · 5 comments

Comments

@HelloDev18
Copy link

Hi, the dialog pops up from the first launch even if debug is false and in real device.
Swift 4. iOS: 11.3. XCode 10.1
My Settings:
SwiftRater.daysUntilPrompt = 3
SwiftRater.usesUntilPrompt = 1
SwiftRater.significantUsesUntilPrompt = 2
SwiftRater.daysBeforeReminding = 2

@takecian
Copy link
Owner

takecian commented Dec 8, 2018

Hello, which version are you using?
What api did you call for showing popup?

@HelloDev18
Copy link
Author

thanks for the quick reply, I use the latest version of your library
SwiftRater.check()

@takecian
Copy link
Owner

takecian commented Dec 8, 2018

Ah, I guess this is because you have set usesUntilPrompt 1.

Shows review request if users launch more than usesUntilPrompt times.

I documented above about usesUntilPrompt, but I checked code now this document is wrong,

Currently my library works "Shows review request if users launch more than equal usesUntilPrompt times."
Could you try setting usesUntilPrompt is 2?

Anyway I will fix code to follow document.

@takecian
Copy link
Owner

takecian commented Dec 8, 2018

I updated, 1.3.1.
This works according to document,

Shows review request if users launch more than usesUntilPrompt times.

@takecian
Copy link
Owner

If you have question more, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants