Skip to content

Commit

Permalink
Merge pull request #378 from jbrobst/pytoml-to-toml
Browse files Browse the repository at this point in the history
Replace 'pytoml' with 'toml'
  • Loading branch information
takluyver committed Nov 19, 2020
2 parents 88b4a6c + b81b1da commit 8f93601
Show file tree
Hide file tree
Showing 12 changed files with 21 additions and 21 deletions.
2 changes: 1 addition & 1 deletion doc/development.rst
Expand Up @@ -5,7 +5,7 @@ To get a development installation of Flit itself::

git clone https://github.com/takluyver/flit.git
cd flit
python3 -m pip install docutils requests pytoml
python3 -m pip install docutils requests toml
python3 bootstrap_dev.py

This links Flit into the current Python environment, so you can make changes
Expand Down
2 changes: 1 addition & 1 deletion doc/pyproject_toml.rst
Expand Up @@ -120,7 +120,7 @@ Here's the full metadata section from flit itself:
"flit_core>=2.2.0",
"requests",
"docutils",
"pytoml",
"toml",
"zipfile36; python_version in '3.3 3.4 3.5'",
]
requires-python=">=3.5"
Expand Down
2 changes: 1 addition & 1 deletion flit/init.py
Expand Up @@ -5,7 +5,7 @@
from pathlib import Path
import re
import sys
import pytoml as toml
import toml

def get_data_dir():
"""Get the directory path for flit user data files.
Expand Down
8 changes: 4 additions & 4 deletions flit/tomlify.py
Expand Up @@ -5,7 +5,7 @@
import configparser
import os
from pathlib import Path
import pytoml
import toml

from .config import metadata_list_fields
from .init import TEMPLATE
Expand Down Expand Up @@ -40,11 +40,11 @@ def convert(path):

written_entrypoints = False
with Path('pyproject.toml').open('w', encoding='utf-8') as f:
f.write(TEMPLATE.format(metadata=pytoml.dumps(metadata)))
f.write(TEMPLATE.format(metadata=toml.dumps(metadata)))

if scripts:
f.write('\n[tool.flit.scripts]\n')
pytoml.dump(scripts, f)
toml.dump(scripts, f)

for groupname, group in entrypoints.items():
if not dict(group):
Expand All @@ -53,7 +53,7 @@ def convert(path):
if '.' in groupname:
groupname = '"{}"'.format(groupname)
f.write('\n[tool.flit.entrypoints.{}]\n'.format(groupname))
pytoml.dump(OrderedDict(group), f)
toml.dump(OrderedDict(group), f)
written_entrypoints = True

print("Written 'pyproject.toml'")
Expand Down
2 changes: 1 addition & 1 deletion flit_core/flit_core/build_thyself.py
Expand Up @@ -25,7 +25,7 @@
'summary': ('Distribution-building parts of Flit. '
'See flit package for more information'),
'requires_dist': [
'pytoml',
'toml',
],
'requires_python': '>=3.4',
'classifiers': [
Expand Down
2 changes: 1 addition & 1 deletion flit_core/flit_core/config.py
Expand Up @@ -3,7 +3,7 @@
import logging
import os
import os.path as osp
import pytoml as toml
import toml
import re

log = logging.getLogger(__name__)
Expand Down
2 changes: 1 addition & 1 deletion flit_core/flit_core/sdist.py
Expand Up @@ -95,7 +95,7 @@ def __init__(self, module, metadata, cfgdir, reqs_by_extra, entrypoints,

@classmethod
def from_ini_path(cls, ini_path: Path):
# Local import so bootstrapping doesn't try to load pytoml
# Local import so bootstrapping doesn't try to load toml
from .config import read_flit_config
ini_info = read_flit_config(ini_path)
srcdir = ini_path.parent
Expand Down
2 changes: 1 addition & 1 deletion flit_core/flit_core/wheel.py
Expand Up @@ -83,7 +83,7 @@ def __init__(self, directory, module, metadata, entrypoints, target_fp):

@classmethod
def from_ini_path(cls, ini_path, target_fp):
# Local import so bootstrapping doesn't try to load pytoml
# Local import so bootstrapping doesn't try to load toml
from .config import read_flit_config
directory = ini_path.parent
ini_info = read_flit_config(ini_path)
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Expand Up @@ -11,7 +11,7 @@ requires=[
"flit_core>=3.0.0",
"requests",
"docutils",
"pytoml",
"toml",
"zipfile36; python_version in '3.3 3.4 3.5'",
]
requires-python=">=3.5"
Expand Down
12 changes: 6 additions & 6 deletions tests/test_init.py
Expand Up @@ -6,7 +6,7 @@
from unittest.mock import patch
import pytest

import pytoml
import toml

from flit import init

Expand Down Expand Up @@ -107,7 +107,7 @@ def test_init():
generated = Path(td) / 'pyproject.toml'
assert_isfile(generated)
with generated.open() as f:
data = pytoml.load(f)
data = toml.load(f)
assert data['tool']['flit']['metadata'][
'author-email'] == "test@example.com"
license = Path(td) / 'LICENSE'
Expand All @@ -131,7 +131,7 @@ def test_init_homepage_and_license_are_optional():
ti = init.TerminalIniter(td)
ti.initialise()
with Path(td, 'pyproject.toml').open() as f:
data = pytoml.load(f)
data = toml.load(f)
assert not Path(td, 'LICENSE').exists()
metadata = data['tool']['flit']['metadata']
assert metadata == {
Expand All @@ -154,7 +154,7 @@ def test_init_homepage_validator():
ti = init.TerminalIniter(td)
ti.initialise()
with Path(td, 'pyproject.toml').open() as f:
data = pytoml.load(f)
data = toml.load(f)
metadata = data['tool']['flit']['metadata']
assert metadata == {
'author': 'Test Author',
Expand All @@ -176,7 +176,7 @@ def test_author_email_field_is_optional():
ti = init.TerminalIniter(td)
ti.initialise()
with Path(td, 'pyproject.toml').open() as f:
data = pytoml.load(f)
data = toml.load(f)
assert not Path(td, 'LICENSE').exists()
metadata = data['tool']['flit']['metadata']
assert metadata == {
Expand Down Expand Up @@ -216,7 +216,7 @@ def test_init_readme_found_yes_choosen():
ti = init.TerminalIniter(td)
ti.initialise()
with Path(td, 'pyproject.toml').open() as f:
data = pytoml.load(f)
data = toml.load(f)

metadata = data['tool']['flit']['metadata']
assert metadata == {
Expand Down
4 changes: 2 additions & 2 deletions tests/test_tomlify.py
@@ -1,6 +1,6 @@
import os
from pathlib import Path
import pytoml
import toml
from shutil import copy
from testpath import assert_isfile

Expand All @@ -18,7 +18,7 @@ def test_tomlify(copy_sample, monkeypatch):
assert_isfile(pyproject_toml)

with pyproject_toml.open(encoding='utf-8') as f:
content = pytoml.load(f)
content = toml.load(f)

assert 'build-system' in content
assert 'tool' in content
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Expand Up @@ -18,7 +18,7 @@ deps =
testpath
responses
docutils
pytoml
toml
pytest>=2.7.3
pytest-cov

Expand Down

0 comments on commit 8f93601

Please sign in to comment.