In PEP 660 mode, the pth must point to an absolute directory

pypa · Oct 2, 2021 · d68674b · d68674b
1 parent 9335bfb
commit d68674b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/flit_core/flit_core/wheel.py b/flit_core/flit_core/wheel.py
@@ -148,7 +148,7 @@ def copy_module(self):
 
     def add_pth(self):
         with self._write_to_zip(self.module.name + ".pth") as f:
-            f.write(str(self.module.source_dir))
+            f.write(str(self.module.source_dir.resolve()))
 
     def write_metadata(self):
         log.info('Writing metadata files')

diff --git a/tests/test_wheel.py b/tests/test_wheel.py
@@ -36,6 +36,23 @@ def test_editable_wheel_module(copy_sample):
         assert pth_path.read_text() == str(td)
         assert_isdir(Path(unpacked, 'module1-0.1.dist-info'))
 
+def test_editable_wheel_has_absolute_pth(copy_sample):
+        td = copy_sample('module1_toml')
+        oldcwd = os.getcwd()
+        os.chdir(str(td))
+        try:
+            make_wheel_in(Path('pyproject.toml'), Path('.'), editable=True)
+            whl_file = 'module1-0.1-py2.py3-none-any.whl'
+            assert_isfile(whl_file)
+            with unpack(whl_file) as unpacked:
+                pth_path = Path(unpacked, 'module1.pth')
+                assert_isfile(pth_path)
+                assert Path(pth_path.read_text()).is_absolute()
+                assert pth_path.read_text() == str(td.resolve())
+                assert_isdir(Path(unpacked, 'module1-0.1.dist-info'))
+        finally:
+            os.chdir(oldcwd)
+
 def test_wheel_package(copy_sample):
     td = copy_sample('package1')
     make_wheel_in(td / 'pyproject.toml', td)