Show a nice error if the configured description-file is missing #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merwok
reviewed
Dec 16, 2018
Co-Authored-By: zenbot <zenbot@gmail.com>
|
Thanks @merwok! |
takluyver
reviewed
Dec 30, 2018
tests/test_inifile.py
Outdated
| def test_missing_description_file(): | ||
| with pytest.raises(ConfigError, match=r"Description file .* does not exist"): | ||
| read_pkg_ini(samples_dir / 'missing-description-file.toml') | ||
| assert re.search(r"Description file .* does not exist", str(error)) |
There was a problem hiding this comment.
I'm assuming that this can be removed now, because the pytest.raises() call will check the same thing?
There was a problem hiding this comment.
@zenbot do you have a minute to remove the redundant line in the test?
There was a problem hiding this comment.
Never mind, I realised I could do it in the web interface on Github. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176.