Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a nice error if the configured description-file is missing #234

Merged
merged 3 commits into from Feb 1, 2019

Conversation

@zenbot
Copy link
Contributor

zenbot commented Nov 13, 2018

Fixes #176.

tests/test_inifile.py Outdated Show resolved Hide resolved
Co-Authored-By: zenbot <zenbot@gmail.com>
@zenbot

This comment has been minimized.

Copy link
Contributor Author

zenbot commented Dec 21, 2018

Thanks @merwok!

def test_missing_description_file():
with pytest.raises(ConfigError, match=r"Description file .* does not exist"):
read_pkg_ini(samples_dir / 'missing-description-file.toml')
assert re.search(r"Description file .* does not exist", str(error))

This comment has been minimized.

Copy link
@takluyver

takluyver Dec 30, 2018

Owner

I'm assuming that this can be removed now, because the pytest.raises() call will check the same thing?

This comment has been minimized.

Copy link
@merwok

merwok Feb 1, 2019

Contributor

Yes

This comment has been minimized.

Copy link
@takluyver

takluyver Feb 1, 2019

Owner

@zenbot do you have a minute to remove the redundant line in the test?

This comment has been minimized.

Copy link
@takluyver

takluyver Feb 1, 2019

Owner

Never mind, I realised I could do it in the web interface on Github. :-)

@takluyver takluyver merged commit a09bf3f into takluyver:master Feb 1, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 84.64%)
Details
codecov/project 84.66% (+0.02%) compared to 8498aa7
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.