removed dead links from example applications #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takluyver
reviewed
Nov 17, 2020
doc/examples.rst
Outdated
Comment on lines
14
to
17
|
|
||
| - `PyQt5 with QML <https://github.com/takluyver/pynsist/tree/master/examples/pyqt5_qml>`_ | ||
| - `PyQt5 with OpenCV <https://github.com/takluyver/pynsist/tree/master/examples/pyqt5_opencv>`_ | ||
|
|
There was a problem hiding this comment.
Sphinx likes blank lines around a sub-list like this. I think it still works without, but it produces a warning, and I try to keep the docs building without warnings, 'cause it's easy to get swamped in a million warnings.
There was a problem hiding this comment.
Ok! I have not used Sphinx before, so I was unaware of this. Thanks!
|
(I also just enabled RTD's Pull Request support, so we now get a status indicator for that too. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #214