Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] MDPDataset: unexpected keyword argument 'create_mask' #51

Closed
pstansell opened this issue Feb 17, 2021 · 2 comments
Closed

[BUG] MDPDataset: unexpected keyword argument 'create_mask' #51

pstansell opened this issue Feb 17, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@pstansell
Copy link
Contributor

pstansell commented Feb 17, 2021

Hello @takuseno,

Running the following code with the most recent version of d3rlpy gives the error below:

from d3rlpy.datasets import get_pendulum
dataset_expert, env = get_pendulum()

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/user/d3rlpy/d3rlpy/datasets.py", line 93, in get_pendulum
    dataset = MDPDataset(
  File "d3rlpy/dataset.pyx", line 141, in d3rlpy.dataset.MDPDataset.__init__
TypeError: __init__() got an unexpected keyword argument 'create_mask'

The problem seems to have been introduced in the "Refactor mask creation" commit here

as the code runs in the commit before that, ie,

@pstansell pstansell added the bug Something isn't working label Feb 17, 2021
@takuseno
Copy link
Owner

@pstansell Hello, the Cython code is changed. Please run this command.

$ python setup.py build_ext --inplace

@pstansell
Copy link
Contributor Author

@takuseno, thank you for your quick response. I didn't realise I had to rebuild parts of the code. After running the command you suggested the code works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants