Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Add algorithm, Critic Regularized Regression #54

Closed
toy101 opened this issue Feb 19, 2021 · 5 comments
Closed

[REQUEST] Add algorithm, Critic Regularized Regression #54

toy101 opened this issue Feb 19, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@toy101
Copy link

toy101 commented Feb 19, 2021

Thank you for creating the great repository.
It is helping me to study reinforcement learning.

if you would not mind, could you implement an offline reinforcement learning algorithm called Critic Regularized Regression (CRR)?
This URL is the paper on the algorithm.
https://arxiv.org/abs/2006.15134

I appreciate this great repository.

@toy101 toy101 added the enhancement New feature or request label Feb 19, 2021
@takuseno
Copy link
Owner

@toy101 Thanks for your request! I'll support this method since the CRR is one of the method that frequently appears in recent papers. I believe this will be available in the next release.

@toy101
Copy link
Author

toy101 commented Feb 20, 2021

Thank you very much!!
I look forward to releasing the next version!

@takuseno
Copy link
Owner

@toy101 Hello, I've made up a draft CRR implementation.
696a9bc

I'll keep working on crr branch since there are still some missing features such as CWP.

@takuseno
Copy link
Owner

@toy101 Hello! CRR is now available in the master branch.
https://github.com/takuseno/d3rlpy/blob/master/d3rlpy/algos/crr.py

Unlike the original paper, d3rlpy does not currently support categorial distributional Q function whereas d3rlpy supports other distributional Q functions such as Quantile Regression. The categorical distributional Q function will be supported later.

@toy101
Copy link
Author

toy101 commented Feb 22, 2021

Thank you!
I'll try to get it running right away!

Thank you so much for implementing this!

@toy101 toy101 closed this as completed Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants