Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation problems on virtual environments with source releases #96

Closed
astrojuanlu opened this issue Jul 20, 2021 · 0 comments · Fixed by #97
Closed

Installation problems on virtual environments with source releases #96

astrojuanlu opened this issue Jul 20, 2021 · 0 comments · Fixed by #97
Labels
bug Something isn't working

Comments

@astrojuanlu
Copy link
Contributor

Describe the bug
I tried pip install . but not all subpackages are installed, for example d3rlpy.models.torch.q_functions (see readthedocs/readthedocs.org#8326).

To Reproduce

  1. Create virtual environment and activate it: python3.7 -m venv .venv && source .venv/bin/activate
  2. Install build dependencies: pip install numpy cython
  3. Run pip install .
  4. Change to a different directory (to avoid importing from the same directory, see https://hynek.me/articles/testing-packaging/#src)
  5. Run import d3rlpy
  6. See crash

Expected behavior
The package source code can be installed and properly imported in a virtual environment.

@astrojuanlu astrojuanlu added the bug Something isn't working label Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant