Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect PR templates #2

Closed
7 tasks
TalAter opened this issue Feb 19, 2016 · 0 comments
Closed
7 tasks

Collect PR templates #2

TalAter opened this issue Feb 19, 2016 · 0 comments
Assignees

Comments

@TalAter
Copy link
Owner

TalAter commented Feb 19, 2016

Questions:

  • Only accept PRs connected to an issue?
  • Require tests?
  • Do you have a CONTRIBUTING file?

Description

Motivation and Context

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.

Credits:

@TalAter TalAter self-assigned this Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant