New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Didn't see file close #183

Closed

xiongjiwei opened this issue May 23, 2020 · 1 comment

Contributor

xiongjiwei commented May 23, 2020

https://github.com/pingcap-incubator/tinykv/blob/b6d7c442e3c9d1eac7192c3bff8372b16a7ae18b/kv/raftstore/snap/snap.go#L680-L685
cannot find where the file closed

Collaborator

Connor1996 commented May 25, 2020

nice catch! Please send a PR to fix it~

xiongjiwei mentioned this issue

close file and refactor function #185

Merged

Connor1996 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment