Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshot did not close file after using #199

Closed
xiongjiwei opened this issue Jun 6, 2020 · 1 comment
Closed

snapshot did not close file after using #199

xiongjiwei opened this issue Jun 6, 2020 · 1 comment

Comments

@xiongjiwei
Copy link
Contributor

https://github.com/pingcap-incubator/tinykv/blob/d13ccb8785702ecdf17368bf2350f7f82c58cab5/kv/raftstore/snap/snap.go#L379-L385

this part is using for building snapshot, it opens metafile and 3 cf files, but it seems the files did not closed. Also, in NewSnapForSending, NewSnapForReceiving, NewSnapForApplying are not close file too.
Or, these files has been closed and I miss something?
@Connor1996
Copy link
Collaborator

seems you're alright. I forget to close the files

@xiongjiwei xiongjiwei mentioned this issue Jun 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Connor1996 @xiongjiwei