when /tmp is under tmpfs (in arch linux) opts.DB.IngestExternalFiles(externalFiles) will block forever

[woodgear]

snap

directio open file issue

change dir in cluster.go could fix this.

[Connor1996]

Thanks for your feedback. Do you have any suggestion to fix it?

[woodgear]

use another dir to avoid tmpfs. for example current_dir/tmp

[rapiz1]

I think this is a critical issue since most Linux distros mount /tmp on tmpfs (systemd feature).
And it took me 2 hours to locate the problem which was in the test, not in my code. It was really an unpleasant experience. At least there should be a caveat in the doc.

[Connor1996]

@rapiz1 Would you mind sending a fix, change the dir or add a caveat warning in the doc.

[wangnengjie]

func (c *Cluster) Start() {
	......
+	_ = os.RemoveAll("./tmp")
+	_ = os.Mkdir("./tmp", 0755|os.ModeDir)
	for storeID := uint64(1); storeID <= uint64(c.count); storeID++ {
-		dbPath, err := ioutil.TempDir("", "test-raftstore")
+		dbPath, err := ioutil.TempDir("./tmp", "test-raftstore")
	......

maybe somewhat like this? Or add mkdir&rm in Makefile.
RemoveAll can be ignored. But when the test failed, the dir will be huge as clients do not call MustDelete.

[rapiz1]

What's the point of using directio here? I think performance and consistency across crash is not an issue since it's just a tutorial project. So we can just simply replace all directio.OpenFile with os.OpenFile and just drop directio out of badger. It works on Arch and it should work everywhere. @Connor1996