Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --https flag for set default protocol as https if not specified #27

Open
talis-fb opened this issue Feb 19, 2024 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers 🐇 Small
Milestone

Comments

@talis-fb
Copy link
Owner

Additional Considerations:

If not exist, in CliInput add a bool field for this and use it for implementation.

There are two possible ways to do that then:

  • Add a input validator. The validator should check the https field and updating the Url string for adding this protocol (if not yet).
  • In parse_inputs_to_request_data you can add in final of function a step for check this field in CliInput and set the protocol in RequestData if it is None.
@talis-fb talis-fb added enhancement New feature or request good first issue Good for newcomers 🐇 Small labels Feb 19, 2024
@talis-fb talis-fb added this to the v1.3.0 milestone Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers 🐇 Small
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant