Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove distinction between single and multiple attachments. #23

Merged
merged 1 commit into from Apr 19, 2020
Merged

Remove distinction between single and multiple attachments. #23

merged 1 commit into from Apr 19, 2020

Conversation

robindijkhof
Copy link
Contributor

When a user decides to use Google Drive instead of a mail client to open the intent, the subject becomes the file name. This is obviously incorrect because it removes the extension of the file. Removing these lines solves this problem. I'm not sure why they were there.

When a user decides to use Google Drive instead of a mail client to open the intent, the subject becomes the file name. This is obviously incorrect because it removes the extension of the file. Removing these lines solves this problem. I'm not sure why they were there.
@taljacobson
Copy link
Owner

thank you for the PR.

ill try to check it out soon.
to make sure there are no adverse effect, the work flow of adding to google drive is not the main flow this package is design/used for.

@robindijkhof
Copy link
Contributor Author

I understand, but af er all it is just an Intent with files attached. The user should be able to open that intent what any app that supports the Intent.

@taljacobson taljacobson merged commit c800e30 into taljacobson:master Apr 19, 2020
@robindijkhof robindijkhof deleted the patch-1 branch April 27, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants