Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validates emailaddress ending with '.' #2

Closed
thomasdc opened this issue Jun 30, 2015 · 4 comments
Closed

Validates emailaddress ending with '.' #2

thomasdc opened this issue Jun 30, 2015 · 4 comments

Comments

@thomasdc
Copy link

Me again :).

I've tested version 2.0, however, the following email addresses succesfully pass the validation process while they shouldn't:

con@firm.ed.
con@firm.ed...
con@firm.ed.++
con@firm.ed---
con@firm.ed--///***-test

Version 1.0 didn't validate them.

@tallesl
Copy link
Owner

tallesl commented Jul 2, 2015

Dang.

I have a last idea.
Get back to you in a few days.

tallesl added a commit that referenced this issue Jul 31, 2015
@tallesl
Copy link
Owner

tallesl commented Jul 31, 2015

Nope, I guess I'll leave as it this.

There's no implementation that covers all the cases (not at all), I'll be running in circles.

I thought of providing multiple implementations and letting the user pick one à la carte, but giving a second thought it felt like too much engineering for such a humble task.

Sorry about that and, anyway, thanks for tests cases 😀

@tallesl tallesl closed this as completed Jul 31, 2015
@thomasdc
Copy link
Author

Well, then I must say I prefer version 1 since that one doesn't allow the above invalid email addresses. Maybe publish version 1 of the nuget as the latest release version?

@tallesl
Copy link
Owner

tallesl commented Aug 7, 2015

Being the nice guy I am, I ended up doing the a la carte thing I've mentioned before.

Version 3.0.0 has it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants