Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated dependency in magic-string #7

Closed
Baroshem opened this issue Jan 17, 2024 · 5 comments
Closed

Deprecated dependency in magic-string #7

Baroshem opened this issue Jan 17, 2024 · 5 comments

Comments

@Baroshem
Copy link

Hey Buddy,

One of the users of Nuxt Security (which uses unplugin-remove under the hood for removing loggers functionality) reported that one of the dependencies of nuxt-security - unplugin-remove and more specifically magic-string has a deprecated dependency and it results in a warning.

More details Baroshem/nuxt-security#342 (comment)

I would really appreciate if you could take a look at it as using deprecated dependencies should be avoided in general.

If you need any assistance from my side, please just let me know and I will do my best to help :)

@Talljack
Copy link
Owner

Yep, I'll check the dependencies of Unplugin-remove, specifically of magic-string as soon as possible.
Thanks for you report, if I have problem need you help me, I'll let you know.

@Talljack
Copy link
Owner

I check the magic-string replace dependencies of sourcemap-codec in 0.27.0, see details for Rich-Harris/magic-string@c87d5eb#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L62
Also sourcemap-codec is deprecated, so I need to upgrade the magic-string to v0.30.5 is okay. @Baroshem

@Baroshem
Copy link
Author

Okay, I am fine with that :)

I will wait for the release with bumped magic-string then :)

@Talljack
Copy link
Owner

Talljack commented Jan 18, 2024

fixed #15
I already released the v0.1.7 version, so you can try it, if have any problems please let me know.

@Baroshem
Copy link
Author

Thanks @Talljack

I will bump the package in Nuxt Security and see how it works there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants