Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger: Upgrade Flow to include dropdown #2623

Open
5 tasks
VladUXUI opened this issue Nov 15, 2022 · 4 comments
Open
5 tasks

Ledger: Upgrade Flow to include dropdown #2623

VladUXUI opened this issue Nov 15, 2022 · 4 comments
Labels
Type: Enhancement New feature or request

Comments

@VladUXUI
Copy link
Contributor

VladUXUI commented Nov 15, 2022

Problem

Since we are adding more chains that don't use Ethereum derivation path, we need a way for users to select what chain they want to start with. Each chain has a different derivation path and a different app that users need to use.

Solution

Start the Ledger Flow by asking users what chain they would like to start with

Changes needed

  • Add select network to First Ledger screen
  • Change content of second scree (Take steps bellow) to tell users what app they need to open (Step 3 - Open Rootstock App)
  • On second screen, add text in graphic to say what chain they selected
  • Error handling inside app (sign tx screens mostly). We need to change the screens that say "Open Ethereum up" to be dependent of chain they are trying to transact with
  • Change flow when users click on "add wallet" for Ledger. Default to what ever chain they are on.

Open question

  • If i onboard with Rootstock, does that mean i won't see my ETH accounts?

Design

image

Figma Link

Figma Link
If you need permission to see, let me know and i'll move it to a public file

@VladUXUI VladUXUI added the Type: Enhancement New feature or request label Nov 15, 2022
@VladUXUI
Copy link
Contributor Author

VladUXUI commented Nov 15, 2022

Going to CC @ahsan-javaiid and @alepc253 since this is needed for Rootstock Ledger onboarding.
I wouldn't consider this a blocker to launching RSK though.

@PabloCastellano
Copy link
Contributor

@VladUXUI Why are you mentioning me? How can I help you?

@VladUXUI
Copy link
Contributor Author

@VladUXUI Why are you mentioning me? How can I help you?

Ups, sorry. That was a mistake. when i type @alepc253 i get you as suggestion.

@ahsan-javaiid
Copy link
Contributor

Hi Tally team 👋

Implementation done here: #2577

Feel free to review the pull request 🙏

@kkosiorowska kkosiorowska removed their assignment Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants