Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all existing context matching to be consistent across the repo #1452

Open
fidgetingbits opened this issue Jun 4, 2024 · 0 comments
Open
Labels
code quality Improvements to code quality

Comments

@fidgetingbits
Copy link
Collaborator

I got confused while doing a review yesterday on #1401 because I happened to be looking at https://github.com/talonhub/community/blob/main/core/application_matches.py around the same time and we are constantly using and where I guess we don't need to. I think almost (not all) of those are redundant?

Also just quickly poking around elsewhere, eg https://github.com/talonhub/community/blob/main/apps/outlook/outlook_win.talon, we are using and where it isn't needed.

Probably makes sense to fix all these to not have superfluous logic, where https://talon.wiki/customization/talon-files/ is probably the best reference of the AND and OR behavior.

If I'm derping here still, I'm happy to be corrected :D

@fidgetingbits fidgetingbits added the code quality Improvements to code quality label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improvements to code quality
Projects
None yet
Development

No branches or pull requests

1 participant