Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vocabulary functions do not strip whitespace from CSV #321

Closed
RobertARandolph opened this issue Jan 8, 2021 · 3 comments · Fixed by #324
Closed

Vocabulary functions do not strip whitespace from CSV #321

RobertARandolph opened this issue Jan 8, 2021 · 3 comments · Fixed by #324

Comments

@RobertARandolph
Copy link
Contributor

I had the misfortune the last few days to believe that the vocabulary csv files were not operating correctly.

Apparently whitespace is not stripped around fields. So "test, test2" leads a row which is parsed, but not turned into a functioning command.
@seabadger
Copy link

this might be the same as talonvoice/talon#199, which was just fixed

@RobertARandolph
Copy link
Contributor Author

this might be the same as talonvoice/talon#199, which was just fixed

I replicated this behaviour using that Talon release, it's still an issue.

@rntz
Copy link
Collaborator

rntz commented Jan 9, 2021

I have a fix for this, I just need to make a PR for it, I should get to it sometime tomorrow.

@rntz rntz mentioned this issue Jan 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

strip whitespace from spoken form in csv-based lists rntz/knausj_talon
3 participants
@rntz @seabadger @RobertARandolph