chore: major cleanup of the code and build #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
There should no functional changes, code was put through `Kres` for automated builds. Go bumped, protobuf & grpc libraries bumped, linting errors fixed, etc. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
Unix4ever
approved these changes
Mar 29, 2021
| @@ -0,0 +1,9 @@ | |||
| # THIS FILE WAS AUTOMATICALLY GENERATED, PLEASE DO NOT EDIT. | |||
There was a problem hiding this comment.
Not related to this PR, but I wonder why markdownlint is fine having these # comments here :)
This doesn't look like a valid json.
There was a problem hiding this comment.
I believe # is a valid comment in JSON
There was a problem hiding this comment.
yeah, probably valid for markdown lint :) But it doesn't look to be a standard.
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should no functional changes, code was put through
Kresforautomated builds.
Go bumped, protobuf & grpc libraries bumped, linting errors fixed, etc.
Signed-off-by: Andrey Smirnov smirnov.andrey@gmail.com