Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add /system directory #2253

Merged
merged 1 commit into from Jul 1, 2020
Merged

feat: add /system directory #2253

merged 1 commit into from Jul 1, 2020

Conversation

andrewrynhard
Copy link
Member

@andrewrynhard andrewrynhard commented Jul 1, 2020 •
edited

This change is Reviewable

@andrewrynhard andrewrynhard added this to the v0.6 milestone Jul 1, 2020
@andrewrynhard andrewrynhard linked an issue Jul 1, 2020 that may be closed by this pull request
Kubelet run directory needs /run/xtables.lock #2251
Closed
@andrewrynhard
Copy link
Member Author

/approve

@andrewrynhard andrewrynhard force-pushed the system-dir branch 4 times, most recently from e8e3824 to ccd7e14 Compare July 1, 2020 05:21
smira
smira previously approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice idea!

@smira
Copy link
Member

smira commented Jul 1, 2020

/promote integration

@andrewrynhard
Copy link
Member Author

/promote e2e

@andrewrynhard
Copy link
Member Author

/promote integration

@alex1989hu
Copy link
Contributor

It solves the Cilium issue 👍

@andrewrynhard
feat: add /system directory
a2e9e09 
This adds the `/system` directory to provide a dedicated
directory for all system related runtime files.

Signed-off-by: Andrew Rynhard <andrew@rynhard.io>
@andrewrynhard
Copy link
Member Author

/promote integration

1 similar comment
@andrewrynhard
Copy link
Member Author

/promote integration

@andrewrynhard
Copy link
Member Author

/lgtm

@andrewrynhard andrewrynhard merged commit 888c8b9 into siderolabs:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsmitty rsmitty rsmitty approved these changes

@smira smira smira left review comments

Assignees
No one assigned
Labels
status/approved status/lgtm
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

Kubelet run directory needs /run/xtables.lock
5 participants
@andrewrynhard @smira @alex1989hu @rsmitty @talos-bot