Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add stub unit-tests to non-trivial Go packages #556

Merged
merged 1 commit into from Apr 17, 2019

Conversation

smira
Copy link
Member

@smira smira commented Apr 17, 2019

This should fix code coverage calculation (code coverage should go down
significantly).

Also fixed two small issues:

  1. Skip containerd tests when it can't run, this allows go test ./...
    in local mode still.

  2. Silence output of go list as we aren't interested in the output, we
    run it to check that go.mod definition is complete.

Signed-off-by: Andrey Smirnov smirnov.andrey@gmail.com

Copy link
Member

@andrewrynhard andrewrynhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #556 into master will decrease coverage by 50.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #556       +/-   ##
==========================================
- Coverage   58.12%   7.36%   -50.77%     
==========================================
  Files           7      57       +50     
  Lines         394    3111     +2717     
==========================================
  Hits          229     229               
- Misses        133    2850     +2717     
  Partials       32      32
Impacted Files Coverage Δ
...pp/init/pkg/system/runner/containerd/containerd.go 80.76% <0%> (ø) ⬆️
internal/pkg/chunker/stream/stream.go 0% <0%> (ø)
cmd/osctl/pkg/client/config/config.go 0% <0%> (ø)
internal/pkg/net/net.go 0% <0%> (ø)
...internal/platform/cloud/googlecloud/googlecloud.go 0% <0%> (ø)
internal/pkg/grpc/factory/factory.go 0% <0%> (ø)
internal/app/init/internal/rootfs/etc/etc.go 0% <0%> (ø)
cmd/osctl/pkg/helpers/should.go 0% <0%> (ø)
internal/pkg/install/prepare.go 0% <0%> (ø)
internal/pkg/mount/options.go 0% <0%> (ø)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d6abdf...44af94d. Read the comment docs.

This should fix code coverage calculation (code coverage should go down
significantly).

Also fixed two small issues:

1. Skip containerd tests when it can't run, this allows `go test ./...`
in local mode still.

2. Silence output of `go list` as we aren't interested in the output, we
run it to check that `go.mod` definition is complete.

Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
@andrewrynhard andrewrynhard merged commit 7da7c8c into siderolabs:master Apr 17, 2019
@andrewrynhard andrewrynhard added this to the v0.1.0-alpha.23 milestone Apr 19, 2019
@andrewrynhard andrewrynhard modified the milestones: v0.1.0-alpha.23, v0.1 Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants