Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onSecureHardwareNotAvailable false positives with freeRASP 6.0.0 #77

Closed
olexale opened this issue Jun 29, 2023 · 6 comments
Closed

onSecureHardwareNotAvailable false positives with freeRASP 6.0.0 #77

olexale opened this issue Jun 29, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@olexale
Copy link

olexale commented Jun 29, 2023

Describe the bug
We are getting many onSecureHardwareNotAvailable callbacks on Android with freeRASP 6.0.0 on devices that work fine with freeRASP 5.0.4. I assume they are false positives caused by some changes in the latest update.

To Reproduce
Upgrade to freeRASP 6, run the app.

Expected behavior
freeRASP doesn't trigger this event.

Please complete the following information:

  • Device: Samsung J5 pro (in fact, many other devices are affected too)
  • OS version: Android 9
  • Version of freeRASP: 6.0.0
@olexale olexale added the bug Something isn't working label Jun 29, 2023
@msikyna
Copy link
Member

msikyna commented Jun 30, 2023

Hello @olexale ,

thank you for reporting this issue! We are looking into it at this moment.

Kind regards,
Talsec team

@xprikryl2
Copy link
Member

xprikryl2 commented Jul 4, 2023

Hi @olexale,

We located one bug regarding this issue, but it only occurs on Android 12 and 13. For API 31 and above, we used this new flag that should indicate whether the device has a hardware keystore. The flag return value is not consistent with the KeyInfo#getSecurityLevel() that we used before. We reverted this change, and the bug should be fixed.

For API 30 and below, the functionality remains the same. We are still using the same method KeyInfo#isInsideSecureHardware(). I tried to look into the logs for any outliers, and my first assumption is that the device you mentioned does not have hardware-backed keystore. Unfortunately, I wasn't able to find any official list or documentation that would support this hypothesis, and we do not have this device available to test it.

image
We will continue with this investigation. If you have this issue on other devices (API 30 and below) and could provide us with a list of these devices, it would be very helpful.

Best regards,
Talsec team

@msikyna
Copy link
Member

msikyna commented Jul 5, 2023

Hello @olexale ,

a new version v6.1.0 fixing the issue has been released. It is also released on pub.dev.

Kind regards,
Talsec team

@olexale
Copy link
Author

olexale commented Jul 5, 2023

Hello @msikyna,

We will give it a try soon. I'll get back to you with the results.
Thank you!

Kind regards,
Oleksandr

@msikyna msikyna added the waiting for response Response from reporter is needed label Jul 5, 2023
@msikyna
Copy link
Member

msikyna commented Aug 4, 2023

Hello @olexale ,
does the issue still persist? Our data implies that it has been fixed.

Kind regards,
Talsec team

@olexale
Copy link
Author

olexale commented Aug 7, 2023

Hello @msikyna,

Thanks for getting back! I don't see this error in recent logs, so I assume it is fixed.

Best regards,
Oleksandr

@olexale olexale closed this as completed Aug 7, 2023
@msikyna msikyna removed the waiting for response Response from reporter is needed label Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants