Only allow request handlers on member invokers (typescript only) #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpbouchard
force-pushed
the
feature/add-invoker-type-checking
branch
from
8df24ad
to
ee5dfe7
Compare
fpbouchard
force-pushed
the
feature/add-invoker-type-checking
branch
from
ee5dfe7
to
dbbc7f4
Compare
|
I was too quick to open this, I'll be back :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a commodity, I've added conditional typing for invoker member names so that they are constrained to only the members that are request handlers. No impact on the generated javascript.